test: relax timer check in test-report-uv-handles.js - #26434
Conversation
Sorry, something went wrong.
|
@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2757/pipeline |
Sorry, something went wrong.
There was a problem hiding this comment.
Ah I left this in accidentally. I actually think printing the uv handle section of the report is quite useful for debugging failures in this test, so I'm inclined to leave it in unless there are objections.
Sorry, something went wrong.
There was a problem hiding this comment.
I don't mind keeping this. It might not be necessary though. If you use any of the report validation functions in test/common/report.js, the full report is printed on failure. That said, if you want to leave this, I'm OK with it.
Sorry, something went wrong.
There was a problem hiding this comment.
In #25852 the test was failing before the call to helper.validateContent().
Sorry, something went wrong.
Sorry, something went wrong.
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21193/ (✔️) |
Sorry, something went wrong.
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: nodejs#26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: nodejs#26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: #26434 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
The underlying JavaScript runtime may schedule tasks at its discretion
so there may be more timer handles than the one created by the test.
Refs: #25852 (comment)
Checklist