FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 5.15.1 by cjihrig · Pull Request #26447 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 5.15.1 - #26447

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint
Mar 10, 2019
ConversationCommits (1)ChecksFiles changed
Merged

tools: update ESLint to 5.15.1#26447
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

cjihrig commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Update ESLint to 5.15.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 5, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2764/pipeline

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 5, 2019
Trott approved these changes Mar 5, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber stamp LGTM.

jasnell commented Mar 5, 2019

Copy link
Copy Markdown
Member

Rubber stamp LGTM

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 5, 2019

silverwind commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Hmm, this commit has some .ts and .map files while dmn@2.1.0 should actually get rid of them.

cjihrig commented Mar 6, 2019

Copy link
Copy Markdown
Contributor Author

I'll wait for #26462 to land and then run the update again before landing this.

silverwind commented Mar 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

To answer my previous question: dmn did not find the files because it does not recurse into module sub-directories or indirect dependencies and doing so seems quite dangerous, so we have to live with these files for now, until a better solution is found.

tools: update ESLint to 5.15.1
2176d63 
Update ESLint to 5.15.1

PR-URL: nodejs#26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig merged commit 2176d63 into nodejs:master Mar 10, 2019
cjihrig deleted the eslint branch March 10, 2019 21:22
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
tools: update ESLint to 5.15.1
3fc4174 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
tools: update ESLint to 5.15.1
2c0c42d 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
tools: update ESLint to 5.15.1
a32c749 
Update ESLint to 5.15.1

PR-URL: #26447
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL