src: merge debug-only SealHandleScopes - #26459
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2774/pipeline |
Sorry, something went wrong.
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us.
bnoordhuis
approved these changes
Mar 5, 2019
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I actually thought of suggesting this in one of your other PRs but then I thought "nah, I'll fix that myself sometime." It's nice that I won't have to now. :-)
Sorry, something went wrong.
Comment thread
src/node_internals.h
Outdated
addaleax
force-pushed
the
sealhandlescope
branch
from
ba2a8fe to
8f3fe6b
Compare
March 5, 2019 22:18
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
BridgeAR
approved these changes
Mar 5, 2019
cjihrig
approved these changes
Mar 6, 2019
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
joyeecheung
approved these changes
Mar 7, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 8, 2019
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: nodejs#26459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: #26459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Instead of repeating the same `#ifdef DEBUG` + `SealHandleScope` pattern over and over, create an utility that does this for us. PR-URL: #26459 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of repeating the same #ifdef DEBUG + SealHandleScope
pattern over and over, create an utility that does this for us.
Checklist