FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: rewrite ocsp test to use mustCall, etc. by sam-github · Pull Request #26460 · nodejs/node · GitHub

/ node Public

test: rewrite ocsp test to use mustCall, etc. - #26460

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:test-ocsp-with-mustcall
ConversationCommits (1)ChecksFiles changed
Closed

test: rewrite ocsp test to use mustCall, etc.#26460
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:test-ocsp-with-mustcall

Conversation

sam-github commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 5, 2019

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2775/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 5, 2019
richardlau approved these changes Mar 5, 2019
View reviewed changes
Comment thread test/parallel/test-tls-ocsp-callback.js Outdated
sam-github force-pushed the test-ocsp-with-mustcall branch 3 times, most recently from a45e5e9 to acd99cb Compare March 5, 2019 23:56

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

Resumed CI https://ci.nodejs.org/job/node-test-commit/26411/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 6, 2019
test: rewrite ocsp test to run in parallel
1126aa4 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.
sam-github force-pushed the test-ocsp-with-mustcall branch from acd99cb to 1126aa4 Compare March 6, 2019 16:17

sam-github commented Mar 6, 2019

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21271/

Changed the commit title, using etc. fools the message linter into thinking the commit description is using sentence punctuation.

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21317/

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

re-ci: https://ci.nodejs.org/job/node-test-pull-request/21340/

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/21355/

BridgeAR commented Mar 8, 2019

Copy link
Copy Markdown
Member

@sam-github I stopped the new CI since the last one passed. Was it intentional to start a new one?

sam-github commented Mar 8, 2019

Copy link
Copy Markdown
Contributor Author

@BridgeAR I thought it passed, too, but git node land did not agree:

   ⚠  Commits were pushed since the last review:
...
? This PR is not ready to land, do you want to continue? (Y/n)

BridgeAR commented Mar 9, 2019

Copy link
Copy Markdown
Member

@sam-github the reason for the complaint is that there is no LG since the last push (due to changing the commit message). It was not about the CI.

BridgeAR approved these changes Mar 9, 2019
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Still LG

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 9, 2019
test: rewrite ocsp test to run in parallel
7891339 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: nodejs#26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

BridgeAR commented Mar 9, 2019

Copy link
Copy Markdown
Member

Landed in 7891339 🎉

BridgeAR closed this Mar 9, 2019
sam-github deleted the test-ocsp-with-mustcall branch March 11, 2019 20:04
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
test: rewrite ocsp test to run in parallel
2258472 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
test: rewrite ocsp test to run in parallel
96d3705 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
test: rewrite ocsp test to run in parallel
d590a45 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
test: rewrite ocsp test to run in parallel
cc0bb02 
Run tests in parallel and use common.mustCall() and mustNotCall()
instead of process.exit() to ensure test assertions are run.

PR-URL: #26460
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL