FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix nits in report docs by vsemozhetbyt · Pull Request #26461 · nodejs/node · GitHub

/ node Public

doc: fix nits in report docs - #26461

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-report-nits
ConversationCommits (1)ChecksFiles changed
Closed

doc: fix nits in report docs#26461
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-report-nits

Conversation

vsemozhetbyt commented Mar 5, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Fix heading levels.
  • Fix section sorting.
  • Add quotes around string values.
  • Remove quotes around property names.

doc: fix nits in report docs
eec5f00 
* Fix heading levels.
* Fix section sorting.
* Add quotes around string values.
* Remove quotes around property names.

nodejs-github-bot commented Mar 5, 2019

Copy link
Copy Markdown
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2776/pipeline

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 5, 2019
vsemozhetbyt added process Issues and PRs related to the process subsystem. report Issues and PRs related to process.report. labels Mar 5, 2019

vsemozhetbyt commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

cjihrig approved these changes Mar 5, 2019
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

Comment thread doc/api/process.md
console.log(`Report directory is ${process.report.directory}`);
```

### process.report.filename

cjihrig Mar 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The sad thing is that I tried to put this in the right place but can't alphabet apparently. Sorry

vsemozhetbyt Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You've got too much on your plate to be sorry about missing nits))

vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Mar 5, 2019

vsemozhetbyt commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 60aaf2c
Thank you for the reviews.

vsemozhetbyt added a commit that referenced this pull request Mar 5, 2019
doc: fix nits in report docs
60aaf2c 
* Fix heading levels.
* Fix section sorting.
* Add quotes around string values.
* Remove quotes around property names.

PR-URL: #26461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
vsemozhetbyt deleted the doc-report-nits branch March 5, 2019 22:52
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
doc: fix nits in report docs
7e40ce1 
* Fix heading levels.
* Fix section sorting.
* Add quotes around string values.
* Remove quotes around property names.

PR-URL: nodejs#26461
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
kissofire mentioned this pull request Mar 7, 2021
Open
aliceUnhinged613 mentioned this pull request Mar 7, 2021
Open
ron-a20 mentioned this pull request Mar 8, 2021
Open
sitedata mentioned this pull request Mar 8, 2021
Open
meghasfdc mentioned this pull request Mar 8, 2021
Open
137717unity mentioned this pull request Mar 8, 2021
Open
Rednickle mentioned this pull request Mar 8, 2021
Open
This was referenced Mar 11, 2021
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
This was referenced May 25, 2021
Open
Open
Open
Open
Open
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Closed
snyk-bot mentioned this pull request Jan 30, 2023
Open
wedataintelligence mentioned this pull request Jan 30, 2023
Open
snyk-bot mentioned this pull request Jan 30, 2023
Open
molllyn1 mentioned this pull request Jan 31, 2023
Open
snyk-bot mentioned this pull request Jan 31, 2023
Open
baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL