doc: edit "Involving the TSC" - #26481
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc.
Copy link
Copy Markdown
Collaborator
|
@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2790/pipeline |
Sorry, something went wrong.
richardlau
approved these changes
Mar 6, 2019
Comment thread
COLLABORATOR_GUIDE.md
Outdated
Co-Authored-By: Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
hiroppy
approved these changes
Mar 7, 2019
Copy link
Copy Markdown
Member
Yes, please! |
Sorry, something went wrong.
targos
approved these changes
Mar 7, 2019
jasnell
approved these changes
Mar 7, 2019
BridgeAR
approved these changes
Mar 7, 2019
BethGriggs
approved these changes
Mar 7, 2019
cjihrig
approved these changes
Mar 7, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 8, 2019
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: nodejs#26481 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 13, 2019
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: nodejs#26481 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: #26481 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Edit the "Involving the TSC" section of the Collaborator Guide to reduce passive voice, make things concise, etc. PR-URL: #26481 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.
One thing I didn't do here but that I would definitely do if there is consensus: Remove mention of the tsc-review label and just tell people to @-mention the TSC. Sure, notification overload is a problem, but the tsc-review label always gets ignored. It's not even a placebo.
Checklist