net: use kHandle symbol for accessing native handle - #26491
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use a common `kHandle` for all `StreamBase`-based streams.
Copy link
Copy Markdown
Collaborator
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2797/pipeline |
Sorry, something went wrong.
mihalskiy
approved these changes
Mar 7, 2019
cjihrig
approved these changes
Mar 7, 2019
joyeecheung
approved these changes
Mar 7, 2019
sam-github
approved these changes
Mar 7, 2019
sam-github
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, though I'm surprised that the req.stream property was unused and could be deleted.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@sam-github Yeah, me too – I don’t think it’s conceptually necessary though, because req.handle[owner_symbol] should also point back to the original Http2Stream? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'm fuzzy on the concept, but if tests pass, its not needed. Not just HTTP2, owner_symbol is also what lib/_tls_wrap.js uses to get back to the stream. |
Sorry, something went wrong.
jasnell
approved these changes
Mar 7, 2019
lpinca
approved these changes
Mar 8, 2019
BridgeAR
approved these changes
Mar 8, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 9, 2019
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: nodejs#26491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: #26491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: nodejs#26491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Use a common `kHandle` for all `StreamBase`-based streams. PR-URL: #26491 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a common kHandle for all StreamBase-based streams.
Checklist