test,doc: add inspector API example for heapdump - #26498
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2801/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Would you consider adding a test case that serves as an example but also ensures this documentation is kept in sync with the code changes in the future? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Test added.
|
Sorry, something went wrong.
cjihrig
approved these changes
Mar 7, 2019
Comment thread
doc/api/inspector.md
Outdated
Comment thread
doc/api/inspector.md
Outdated
Comment thread
doc/api/inspector.md
Outdated
Comment thread
doc/api/inspector.md
Outdated
richardlau
approved these changes
Mar 7, 2019
eugeneo
approved these changes
Mar 7, 2019
eugeneo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
addaleax
reviewed
Mar 7, 2019
Comment thread
doc/api/inspector.md
Outdated
lpinca
approved these changes
Mar 7, 2019
addaleax
approved these changes
Mar 7, 2019
Comment thread
doc/api/inspector.md
Outdated
4 tasks
BridgeAR
approved these changes
Mar 8, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Mar 8, 2019
sam-github
force-pushed
the
doc-heapdump-example
branch
from
3a31f6d to
c75c84d
Compare
March 8, 2019 22:52
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
sam-github
force-pushed
the
doc-heapdump-example
branch
from
c75c84d to
02691ce
Compare
March 8, 2019 23:49
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
danbev
pushed a commit
that referenced
this pull request
Mar 11, 2019
PR-URL: #26498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
PR-URL: #26498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
PR-URL: #26498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced May 29, 2019
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. nodejs/diagnostics#279
Checklist