process: add --pending-deprecation to process.binding() - #26500
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Print a deprecation warning for `process.binding()` when using `--pending-deprecation`.
Copy link
Copy Markdown
Collaborator
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2804/pipeline |
Sorry, something went wrong.
richardlau
approved these changes
Mar 7, 2019
cjihrig
approved these changes
Mar 7, 2019
Comment thread
lib/internal/bootstrap/pre_execution.js
Outdated
Trott
approved these changes
Mar 7, 2019
devsnek
approved these changes
Mar 7, 2019
joyeecheung
approved these changes
Mar 7, 2019
jasnell
approved these changes
Mar 7, 2019
JungMinu
approved these changes
Mar 8, 2019
targos
approved these changes
Mar 8, 2019
shisama
approved these changes
Mar 8, 2019
BridgeAR
approved these changes
Mar 8, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/build @nodejs/automation our bot does not seem to detect process related PRs properly (the label is not applied). |
Sorry, something went wrong.
tniessen
approved these changes
Mar 8, 2019
Comment thread
doc/api/deprecations.md
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
None of the files changed in this PR are exclusive to process though. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I guess it should be safe to map lib/internal/bootstrap/* changes to process |
Sorry, something went wrong.
ChALkeR
approved these changes
Mar 8, 2019
ChALkeR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
👍
Sorry, something went wrong.
antsmartian
approved these changes
Mar 9, 2019
Copy link
Copy Markdown
Member
Author
|
Landed in 148254744134793cd6556c9749658f3872b03d002 |
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Mar 11, 2019
Print a deprecation warning for `process.binding()` when using `--pending-deprecation`. PR-URL: #26500 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Print a deprecation warning for `process.binding()` when using `--pending-deprecation`. PR-URL: #26500 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Print a deprecation warning for `process.binding()` when using `--pending-deprecation`. PR-URL: #26500 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print a deprecation warning for process.binding() when using
--pending-deprecation.
Checklist