process: patch more process properties during pre-execution - #26517
Closed
joyeecheung wants to merge 3 commits into
Closed
process: patch more process properties during pre-execution#26517joyeecheung wants to merge 3 commits into
joyeecheung wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Since these depends on process runtime states, delay them until pre-execution.
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap.
Copy link
Copy Markdown
Collaborator
|
@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2811/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
approved these changes
Mar 8, 2019
BridgeAR
approved these changes
Mar 8, 2019
Comment thread
lib/internal/bootstrap/pre_execution.js
Outdated
Comment thread
src/node_process_object.cc
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Mar 12, 2019
Since these depends on process runtime states, delay them until pre-execution. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
joyeecheung
added a commit
that referenced
this pull request
Mar 12, 2019
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Member
|
This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly. |
Sorry, something went wrong.
4 tasks
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
Since these depends on process runtime states, delay them until pre-execution. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Since these depends on process runtime states, delay them until pre-execution. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process: delay process.argv[0] and process.argv0 handling
Since these depends on process runtime states, delay them until
pre-execution.
process: create legacy process properties during pre-execution
Shim legacy process object properties of CLI options during
pre-execution instead of serializing them during bootstrap.
Checklist