report: fix formatting and add coverage for stdout/stderr - #26522
Merged
cjihrig merged 2 commits intoMar 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2816/pipeline |
Sorry, something went wrong.
addaleax
approved these changes
Mar 8, 2019
richardlau
approved these changes
Mar 8, 2019
Copy link
Copy Markdown
Member
|
CI https://ci.nodejs.org/job/node-test-pull-request/21349/ EDIT(cjihrig): CI was green. |
Sorry, something went wrong.
jasnell
approved these changes
Mar 10, 2019
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: nodejs#26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: nodejs#26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Landed in 3194744...86aed6d. |
Sorry, something went wrong.
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
This commit prevents the report and "report complete" message from being printed on the same line. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
This commit adds coverage for the cases where process.report.filename is 'stdout' or 'stderr'. PR-URL: #26522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When process.report.filename is 'stdout' or 'stderr', the output runs together. This PR fixes that, and also improves test coverage.
Checklist