FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix nits in writing-tests.md by vsemozhetbyt · Pull Request #26543 · nodejs/node · GitHub

/ node Public

doc: fix nits in writing-tests.md - #26543

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-test-console
Closed

doc: fix nits in writing-tests.md#26543
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-test-console

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Correct a typo.
  • Normalize spaces.
  • Split a paragraph with different topics.

* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 9, 2019
vsemozhetbyt added the test Issues and PRs related to the tests. label Mar 9, 2019

Copy link
Copy Markdown
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Mar 9, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 4e9dc31
Thank you for the reviews.

vsemozhetbyt deleted the doc-test-console branch March 9, 2019 12:18
vsemozhetbyt added a commit that referenced this pull request Mar 9, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
* Correct a typo.
* Normalize spaces.
* Split a paragraph with different topics.

PR-URL: #26543
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL