FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix syntax error in test-dns-idna2008.js when failing by refack · Pull Request #26570 · nodejs/node · GitHub

/ node Public

test: fix syntax error in test-dns-idna2008.js when failing - #26570

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:fix-idna2008-test++
Mar 12, 2019
ConversationCommits (1)ChecksFiles changed
Merged

test: fix syntax error in test-dns-idna2008.js when failing#26570
refack merged 1 commit into
nodejs:masterfrom
refack:fix-idna2008-test++

Conversation

refack commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

Refs: #25870
Refs: #26473

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

refack added dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 10, 2019
refack self-assigned this Mar 10, 2019

nodejs-github-bot commented Mar 10, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2848/pipeline

refack mentioned this pull request Mar 10, 2019
Closed

refack commented Mar 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5188/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5189/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5190/ worker-1 ✔️
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5191/ worker-2 ✔️

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 10, 2019
refack added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 10, 2019

refack commented Mar 10, 2019

Copy link
Copy Markdown
Contributor Author

Actually since right now master is broken, I'd like to fast-track this.
Please 👍 here.

Trott reviewed Mar 10, 2019
View reviewed changes
Comment thread test/internet/test-dns-idna2008.js Outdated

refack commented Mar 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

New CI:
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5204/ worker-1 ✔️
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5205/ worker-2 ✔️

bnoordhuis reviewed Mar 11, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you mention in the commit log the commit that introduced the bug? It's 9613221 "test: de-flake test-dns-idna2008.js", isn't it?

refack force-pushed the fix-idna2008-test++ branch from 57eac2d to 8b6d454 Compare March 11, 2019 15:50

refack commented Mar 11, 2019

Copy link
Copy Markdown
Contributor Author

Can you mention in the commit log the commit that introduced the bug

Done.

refack commented Mar 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ping @nodejs/testing, I'd like to land this tonight to unbreak master, PTAL.

CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5243/

test: fix syntax error in test-dns-idna2008.js when failing
f77555f 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 12, 2019
refack force-pushed the fix-idna2008-test++ branch from 8b6d454 to f77555f Compare March 12, 2019 15:12
refack merged commit f77555f into nodejs:master Mar 12, 2019
refack deleted the fix-idna2008-test++ branch March 12, 2019 15:16
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
test: fix syntax error in test-dns-idna2008.js when failing
f03498c 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
test: fix syntax error in test-dns-idna2008.js when failing
f2eeb38 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
test: fix syntax error in test-dns-idna2008.js when failing
155cc34 
Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570
Refs: nodejs#25870
Refs: nodejs#26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
test: fix syntax error in test-dns-idna2008.js when failing
e1a55e7 
Fixes a bug I introduced in 9613221

PR-URL: #26570
Refs: #25870
Refs: #26473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack removed their assignment Mar 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL