doc: edit "Using git-node" section of Guide - #26580
Closed
Trott wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc.
Copy link
Copy Markdown
Collaborator
|
@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2858/pipeline |
Sorry, something went wrong.
richardlau
approved these changes
Mar 11, 2019
Comment thread
COLLABORATOR_GUIDE.md
Outdated
danbev
approved these changes
Mar 11, 2019
shisama
approved these changes
Mar 11, 2019
mihalskiy
approved these changes
Mar 11, 2019
cjihrig
approved these changes
Mar 11, 2019
Co-Authored-By: Trott <rtrott@gmail.com>
vsemozhetbyt
approved these changes
Mar 11, 2019
Copy link
Copy Markdown
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Sorry, something went wrong.
BethGriggs
approved these changes
Mar 11, 2019
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 11, 2019
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: nodejs#26580 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: #26580 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: #26580 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: #26580 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit the "Using git-node" section of the Collaborator Guide. Make
sentences concise and clear, reduce use of passive voice, etc.
Checklist