FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-worker-prof as flake on all platforms by refack · Pull Request #26600 · nodejs/node · GitHub

/ node Public

test: mark test-worker-prof as flake on all platforms - #26600

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:makr-flake-test-worker-prof
Mar 12, 2019
ConversationCommits (1)ChecksFiles changed
Merged

test: mark test-worker-prof as flake on all platforms#26600
refack merged 1 commit into
nodejs:masterfrom
refack:makr-flake-test-worker-prof

Conversation

refack commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

Refs: #26401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Mar 11, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2872/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2019
refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 11, 2019

refack commented Mar 11, 2019

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21441/

If this passes, I'd like to fast-track it.
Please 👍 .

refack commented Mar 11, 2019

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/testing

test: mark test-worker-prof as flake on all platforms
e1cd8ac 
PR-URL: nodejs#26600
Refs: nodejs#26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack force-pushed the makr-flake-test-worker-prof branch from 4f837a1 to e1cd8ac Compare March 12, 2019 00:39
refack merged commit e1cd8ac into nodejs:master Mar 12, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
test: mark test-worker-prof as flake on all platforms
300ad04 
PR-URL: #26600
Refs: #26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
test: mark test-worker-prof as flake on all platforms
2c55282 
PR-URL: #26600
Refs: #26401
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack deleted the makr-flake-test-worker-prof branch April 14, 2019 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL