FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add Note of options.stdio into child_process by koh110 · Pull Request #26604 · nodejs/node · GitHub

/ node Public

doc: add Note of options.stdio into child_process - #26604

Closed
koh110 wants to merge 1 commit into
nodejs:masterfrom
koh110:doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: add Note of options.stdio into child_process#26604
koh110 wants to merge 1 commit into
nodejs:masterfrom
koh110:doc

Conversation

koh110 commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

add Note of options.stdio into child_process.

Ref: #22892 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 12, 2019

koh110 commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

@addaleax @Trott @bzoz That is a continuation #22892. Would you approve it?

addaleax reviewed Mar 12, 2019
View reviewed changes
Comment thread doc/api/child_process.md Outdated
addaleax approved these changes Mar 12, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

cjihrig approved these changes Mar 12, 2019
View reviewed changes
Comment thread doc/api/child_process.md Outdated
bzoz suggested changes Mar 12, 2019
View reviewed changes

bzoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Passing file descriptors works fine on Windows, its just sockets that are not supported.

vsemozhetbyt added the windows Issues and PRs related to the Windows platform. label Mar 12, 2019

koh110 commented Mar 12, 2019

Copy link
Copy Markdown
Contributor Author

I see. I think first sentence is better. I thought that file handle and file descriptors are slightly different.
So, I would change Passing sockets does not supported on Windows..
@addaleax @cjihrig @bzoz

addaleax commented Mar 12, 2019

Copy link
Copy Markdown
Member

But in that case it’s probably not right to put it just under this particular type of option? Passing in a net.Socket object, rather than a file descriptor, is invalid on Windows too then, right?

Trott reviewed Mar 12, 2019
View reviewed changes
Comment thread doc/api/child_process.md Outdated

Trott Mar 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
does not supported on Windows.
is not supported on Windows.

koh110 commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

Windows allow named pipe. I think Passing in a net.Socket object is valid on Windows.
But I feel like that file descriptors might be intelligible phrase more than Passing sockets.
Umm...

It's valid on Windows.
https://github.com/nodejs/node/blob/master/test/common/index.js#L176-L181

require('net').createServer((conn) => {
    stdio: ['ignore', conn, 'ignore']
  });
}).listen(common.PIPE, () => {});

koh110 commented Mar 15, 2019

Copy link
Copy Markdown
Contributor Author

I have no preference. How about this change? @addaleax @cjihrig

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 16, 2019

addaleax commented Mar 16, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2936/pipeline

danbev commented Mar 19, 2019

Copy link
Copy Markdown
Contributor

Landed in e08ac04.

danbev closed this Mar 19, 2019
danbev pushed a commit that referenced this pull request Mar 19, 2019
doc: add Note of options.stdio into child_process
e08ac04 
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
doc: add Note of options.stdio into child_process
3fa878b 
PR-URL: nodejs#26604
Refs: nodejs#22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
doc: add Note of options.stdio into child_process
148c2ca 
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
doc: add Note of options.stdio into child_process
bc7449c 
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
BethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
doc: add Note of options.stdio into child_process
09f162b 
PR-URL: #26604
Refs: #22892 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
bzoz bzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL