Revert "crypto: add KeyObject.asymmetricKeySize" - #26636
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 4895927. Fixes: nodejs#26631
Copy link
Copy Markdown
Collaborator
|
@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2893/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@tniessen I just saw this. I'll back out the PR from the next release and add do not land tags until this is resolved. |
Sorry, something went wrong.
ryzokuken
approved these changes
Mar 14, 2019
ryzokuken
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM as the said method sets false expectations as discussed in the issue.
Sorry, something went wrong.
Trott
approved these changes
Mar 14, 2019
bnoordhuis
approved these changes
Mar 15, 2019
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4895927 (#26387). While a similar API would be useful, I think the API should not have landed as it is, see #26631 and #26631 (comment).
Fixes: #26631
cc @nodejs/crypto
Checklist