url: add ws: and wss: to slashedProtocol set - #26941
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fix cases where the pathname is incorrectly parsed as `null`.
Copy link
Copy Markdown
Collaborator
|
@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3066/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The legacy URL API is deprecated but I think bug fixes are still accepted? url.parse() is heavily used. |
Sorry, something went wrong.
mihalskiy
approved these changes
Mar 27, 2019
cjihrig
approved these changes
Mar 27, 2019
BridgeAR
approved these changes
Mar 27, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ZYSzys
approved these changes
Mar 28, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
Fix cases where the pathname is incorrectly parsed as `null`. PR-URL: #26941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Fix cases where the pathname is incorrectly parsed as `null`. PR-URL: #26941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 8, 2019
Fix cases where the pathname is incorrectly parsed as `null`. PR-URL: #26941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
3 tasks
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Nov 10, 2019
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. Fixes: nodejs#30154 Refs: nodejs#26941
lpinca
added a commit
that referenced
this pull request
Nov 15, 2019
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. PR-URL: #30348 Fixes: #30154 Refs: #26941 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. PR-URL: #30348 Fixes: #30154 Refs: #26941 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. PR-URL: #30348 Fixes: #30154 Refs: #26941 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. PR-URL: #30348 Fixes: #30154 Refs: #26941 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cases where the pathname is incorrectly parsed as null.
Checklist