FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update nghttp2 to 1.37.0 by gengjiawen · Pull Request #26990 · nodejs/node · GitHub

/ node Public

deps: update nghttp2 to 1.37.0 - #26990

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:deps_nghttp2
ConversationCommits (1)ChecksFiles changed
Closed

deps: update nghttp2 to 1.37.0#26990
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:deps_nghttp2

Conversation

gengjiawen commented Mar 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

See https://github.com/nghttp2/nghttp2/releases.

Maybe need to add label semver-minor ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 29, 2019

targos commented Mar 31, 2019

Copy link
Copy Markdown
Member

@nodejs/http2

targos added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 31, 2019

nodejs-github-bot commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22052/

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 31, 2019
mcollina approved these changes Mar 31, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ZYSzys commented Apr 3, 2019

Copy link
Copy Markdown
Member

Landed in 5c2ee4e 🎉

ZYSzys closed this Apr 3, 2019
ZYSzys pushed a commit that referenced this pull request Apr 3, 2019
deps: update nghttp2 to 1.37.0
5c2ee4e 
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
deps: update nghttp2 to 1.37.0
a674006 
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
deps: update nghttp2 to 1.37.0
247700f 
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
deps: update nghttp2 to 1.37.0
3e4c03d 
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 10, 2019
2019-04-10, Version 11.14.0 (Current)
ebfb67a 
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
2019-04-11, Version 11.14.0 (Current)
cd026f8 
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
2019-04-11, Version 11.14.0 (Current)
d424560 
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163
gengjiawen deleted the deps_nghttp2 branch April 12, 2019 03:16
BethGriggs pushed a commit that referenced this pull request Aug 15, 2019
deps: update nghttp2 to 1.37.0
ab0f2ac 
Backport-PR-URL: #29123
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs mentioned this pull request Aug 15, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Aug 15, 2019
deps: update nghttp2 to 1.37.0
0b44733 
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

sam-github commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

@nodejs/http2 This was labelled semver-minor, but it isn't clear why.

The underlying nghttp2 (assuming it is using semver) jumped a minor, but that doesn't necessarily get reflected in node.

Is it actually minor?

BethGriggs mentioned this pull request Aug 15, 2019
Closed
addaleax removed the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 15, 2019

addaleax commented Aug 15, 2019

Copy link
Copy Markdown
Member

Just removed the label, this isn’t semver-minor for us.

This was referenced Aug 15, 2019
Closed
Merged
andrewhughes101 added a commit to andrewhughes101/node that referenced this pull request Aug 16, 2019
doc: fixup changelog for v10.16.3
30f30e2 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: nodejs#26990
BethGriggs pushed a commit that referenced this pull request Aug 16, 2019
doc: fixup changelog for v10.16.3
791409a 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
doc: fixup changelog for v10.16.3
a3eda28 
Remove (SEMVER-MINOR) label from patch commit. Add link to table.

Refs: #26990

PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL