crypto: simplify missing passphrase detection - #27089
Closed
tniessen wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
sam-github
reviewed
Apr 4, 2019
Comment thread
src/node_crypto.cc
Outdated
sam-github
approved these changes
Apr 4, 2019
sam-github
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code looks good. Its completely backwards compatible? No test changes needed at all? If so, its nice to delete code!
Sorry, something went wrong.
danbev
approved these changes
Apr 5, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnoordhuis
approved these changes
Apr 5, 2019
Comment thread
src/node_crypto.cc
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
As far as I know, there should be no difference whatsoever. |
Sorry, something went wrong.
jasnell
approved these changes
Apr 6, 2019
danbev
pushed a commit
that referenced
this pull request
Apr 8, 2019
PR-URL: #27089 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
This was referenced Jan 12, 2022
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the PasswordCallbackInfo class introduced in #25208 and uses existing OpenSSL error handling APIs to detect missing passphrases instead. This should not cause any observable differences for users, but slightly simplifies and shortens our code.
Checklist