FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: link bigint type to MDN instead of proposal by vsemozhetbyt · Pull Request #27101 · nodejs/node · GitHub

/ node Public

doc: link bigint type to MDN instead of proposal - #27101

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-bigint-mdn
Closed

doc: link bigint type to MDN instead of proposal#27101
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-bigint-mdn

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

It is not an ideal solution yet: bigint as a new primitive currently absent in the MDN section we usually link primitives to, so we need to refer to a global object which may be a bit confusing. But maybe this is better than to link to the proposal now.

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Apr 5, 2019
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 5, 2019

Copy link
Copy Markdown
Contributor Author

Landed in 1afec97
Thank you for the reviews.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL