build: increase MACOS_DEPLOYMENT_TARGET to 10.10 for Node 12 - #27275
Closed
rvagg wants to merge 1 commit into
Closed
build: increase MACOS_DEPLOYMENT_TARGET to 10.10 for Node 12#27275rvagg wants to merge 1 commit into
rvagg wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/build |
Sorry, something went wrong.
25 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnoordhuis
approved these changes
Apr 17, 2019
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but personally I'd go a step further and move up to 10.11 (El Capitan.) Apple stopped supporting 10.10 almost two years ago so why should we?
Sorry, something went wrong.
cjihrig
approved these changes
Apr 17, 2019
Copy link
Copy Markdown
Contributor
|
I like dropping some stats for making this kind of educated guesses |
Sorry, something went wrong.
rvagg
added a commit
that referenced
this pull request
Apr 18, 2019
PR-URL: #27275 Refs: #26714 Refs: nodejs/build#1768 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #26714
Ref: nodejs/build#1768
This is part of the Node 12 compiler & supported platforms work. It was last bumped in #6402 in 2016.
From #26714:
But I'll add that I'm not fully confident about this, I'm still hoping for help making this decision.
10.9 is Mavericks, it was released in 2013 and had its last security update mid-2016. This change will mean that 10.9 and prior versions won't be able to run Node binaries because they'll (probably) have newer symbols.
If, for some reason, we find that 10.10 is too aggressive, we can always roll this back a bit without it being a breaking change, we just can't roll it forward for the lifetime of Node 12.