FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

worker: add ability to unshift message from MessagePort by addaleax · Pull Request #27294 · nodejs/node · GitHub

/ node Public

worker: add ability to unshift message from MessagePort - #27294

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:messageport-single-message
ConversationCommits (1)ChecksFiles changed
Closed

worker: add ability to unshift message from MessagePort#27294
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:messageport-single-message

Conversation

addaleax commented Apr 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
worker: move receiving_messages_ field to MessagePort (landed as part of #27705)

This is a property of the native object associated with the
MessagePort, not something that should be set on the
conceptual MessagePort that may be transferred around.

(This is just cleanup that’s not directly related to the next commit except
for merge conflicts.)

worker: add ability to unshift message from MessagePort

In combination with Atomics, this makes it possible to implement
generic synchronous functionality, e.g. importScript(), in Workers
purely by communicating with other threads.

This is a continuation of #26686,
where a preference for a solution was voiced that allowed reading
individual messages, rather than emitting all messages through events.

(/cc @devsnek, @BridgeAR, @nodejs/workers)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax added semver-minor PRs that contain new features and should be released in the next minor version. worker Issues and PRs related to Worker support. labels Apr 18, 2019

nodejs-github-bot commented Apr 18, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3294

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 18, 2019

addaleax commented Apr 24, 2019

Copy link
Copy Markdown
Member Author

Ping @nodejs/workers

nodejs-github-bot commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22691/

benjamingr approved these changes Apr 25, 2019
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The actual code LGTM the two concerns I have is:

  • Wouldn't it be better to provide an API that makes the ports AsyncIterable instead of adding this?
  • Are we OK adding this given there is no equivalent?

Actual code LGTM and if you find it useful I'm good with it.

addaleax commented Apr 25, 2019

Copy link
Copy Markdown
Member Author

Wouldn't it be better to provide an API that makes the ports AsyncIterable instead of adding this?

@benjamingr I think that async interation is of limited usefulness for APIs that refer to external events, like messages from another thread… but I wouldn’t mind making EventEmitter APIs AsyncIterable in general, similar to the API we have for readline.

Are we OK adding this given there is no equivalent?

You mean, no browser equivalent? I’m personally okay with that, yes – if we don’t want this, that’s okay, but I’d still prefer to make some way of transferring arbitrary data synchronously possible.

chjj added a commit to chjj/bthreads that referenced this pull request Apr 30, 2019
bthreads: expose receiveMessageOnPort. see nodejs/node#27294.
adcc5c4

nodejs-github-bot commented May 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23063/

addaleax force-pushed the messageport-single-message branch from d4e82e4 to 248a203 Compare May 14, 2019 12:13

addaleax commented May 14, 2019

Copy link
Copy Markdown
Member Author

Got around to fixing CI for this, had to revert a bit of the last commit.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 14, 2019

nodejs-github-bot commented May 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23108/

benjamingr commented May 14, 2019

Copy link
Copy Markdown
Member

Still lgtm

nodejs-github-bot commented May 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23124/

addaleax mentioned this pull request May 14, 2019
Closed
3 tasks
worker: add ability to unshift message from MessagePort
8bd751a 
In combination with Atomics, this makes it possible to implement
generic synchronous functionality, e.g. `importScript()`, in Workers
purely by communicating with other threads.

This is a continuation of nodejs#26686,
where a preference for a solution was voiced that allowed reading
individual messages, rather than emitting all messages through events.
addaleax force-pushed the messageport-single-message branch from 248a203 to 8bd751a Compare May 19, 2019 12:46

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23197/

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23200/

nodejs-github-bot commented May 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23206/

addaleax commented May 19, 2019

Copy link
Copy Markdown
Member Author

Landed in 76f2168

addaleax closed this May 19, 2019
addaleax deleted the messageport-single-message branch May 19, 2019 20:10
addaleax added a commit that referenced this pull request May 19, 2019
worker: add ability to unshift message from MessagePort
76f2168 
In combination with Atomics, this makes it possible to implement
generic synchronous functionality, e.g. `importScript()`, in Workers
purely by communicating with other threads.

This is a continuation of #26686,
where a preference for a solution was voiced that allowed reading
individual messages, rather than emitting all messages through events.

PR-URL: #27294
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 20, 2019
worker: add ability to unshift message from MessagePort
c7cf8d9 
In combination with Atomics, this makes it possible to implement
generic synchronous functionality, e.g. `importScript()`, in Workers
purely by communicating with other threads.

This is a continuation of #26686,
where a preference for a solution was voiced that allowed reading
individual messages, rather than emitting all messages through events.

PR-URL: #27294
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request May 21, 2019
2019-05-21, Version 12.3.0 (Current)
e0afe0e 
Notable changes:

* process:
  * Log errors using `util.inspect` in case of fatal exceptions
    (Ruben Bridgewater) #27243
* repl:
  * Add `process.on('uncaughtException')` support (Ruben Bridgewater)
    #27151
* stream:
  * Implemented `Readable.from` async iterator utility (Guy Bedford)
    #27660
* tls:
  * Expose built-in root certificates (Ben Noordhuis)
    #26415
  * Support `net.Server` options (Luigi Pinca)
    #27665
  * Expose `keylog` event on TLSSocket (Alba Mendez)
    #27654
* worker:
  * Added the ability to unshift messages from the `MessagePort`
    (Anna Henningsen) #27294
BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
BridgeAR added a commit that referenced this pull request May 21, 2019
2019-05-21, Version 12.3.0 (Current)
20c11be 
Notable changes:

* esm:
  * Added the `--experimental-wasm-modules` flag to support
    WebAssembly modules (Myles Borins & Guy Bedford)
    #27659
* process:
  * Log errors using `util.inspect` in case of fatal exceptions
    (Ruben Bridgewater) #27243
* repl:
  * Add `process.on('uncaughtException')` support (Ruben Bridgewater)
    #27151
* stream:
  * Implemented `Readable.from` async iterator utility (Guy Bedford)
    #27660
* tls:
  * Expose built-in root certificates (Ben Noordhuis)
    #26415
  * Support `net.Server` options (Luigi Pinca)
    #27665
  * Expose `keylog` event on TLSSocket (Alba Mendez)
    #27654
* worker:
  * Added the ability to unshift messages from the `MessagePort`
    (Anna Henningsen) #27294

PR-URL: #27799
BridgeAR added a commit that referenced this pull request May 21, 2019
2019-05-21, Version 12.3.0 (Current)
9fec70a 
Notable changes:

* esm:
  * Added the `--experimental-wasm-modules` flag to support
    WebAssembly modules (Myles Borins & Guy Bedford)
    #27659
* process:
  * Log errors using `util.inspect` in case of fatal exceptions
    (Ruben Bridgewater) #27243
* repl:
  * Add `process.on('uncaughtException')` support (Ruben Bridgewater)
    #27151
* stream:
  * Implemented `Readable.from` async iterator utility (Guy Bedford)
    #27660
* tls:
  * Expose built-in root certificates (Ben Noordhuis)
    #26415
  * Support `net.Server` options (Luigi Pinca)
    #27665
  * Expose `keylog` event on TLSSocket (Alba Mendez)
    #27654
* worker:
  * Added the ability to unshift messages from the `MessagePort`
    (Anna Henningsen) #27294

PR-URL: #27799
richardlau mentioned this pull request Jul 2, 2020
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL