process: improve nextTick performance - #27347
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This comment has been minimized.
apapirovski
force-pushed
the
patch-next-tick-perf
branch
from
4e37387 to
f5e1032
Compare
April 22, 2019 18:57
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
FWIW my PR for improving nextTick performance isn't abandoned, I just haven't had time to revisit it yet. Also, this PR is now exposing asyncId and triggerAsyncId on the object passed to the hook(s) more directly. I think we should be hiding those sorts of things from hooks, as I believe that may be why Symbols were used in the first place. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
👍 will remove from here. |
Sorry, something went wrong.
No longer check process.exiting on each tick add. Cleaner emitDestroy with try/finally. No longer use Reflect.apply since it's slower.
apapirovski
force-pushed
the
patch-next-tick-perf
branch
from
f5e1032 to
4d82fd8
Compare
April 22, 2019 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/22633/
Checklist