FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace HTTPPARSER by new resource names by Flarna · Pull Request #27372 · nodejs/node · GitHub

/ node Public

test: replace HTTPPARSER by new resource names - #27372

Closed
Flarna wants to merge 1 commit into
nodejs:masterfrom
Flarna:rename_httpparser
ConversationCommits (1)ChecksFiles changed
Closed

test: replace HTTPPARSER by new resource names#27372
Flarna wants to merge 1 commit into
nodejs:masterfrom
Flarna:rename_httpparser

Conversation

Flarna commented Apr 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

The async resource HTTPPARSER has been replaced by
HTTPINCOMINGMESSAGE and HTTPCLIENTREQUEST but some tests have
not been adapted.

As test test-graph.http.js has not failed even it asserted on
HTTPPARSER I improved verify-graph and adapted the asserts in
test-graph.tls-write which failed because of the stricter check.

Refs: #25094

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Apr 23, 2019
test: replace HTTPPARSER by new resource names
311ecd8 
The async resource `HTTPPARSER` has been replaced by
`HTTPINCOMINGMESSAGE` and `HTTPCLIENTREQUEST` but some tests have
not been adapted.

As test test-graph.http.js has not failed even it asserted on
´HTTPPARSER` I improved `verify-graph` and adapted the asserts in
test-graph.tls-write which failed because of the stricter check.

Refs: #25094

nodejs-github-bot commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22668/

Trott approved these changes Apr 23, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI passes

Trott reviewed Apr 23, 2019
View reviewed changes
Comment thread test/parallel/test-async-hooks-http-parser-destroy.js
async_hooks.createHook({
init: common.mustCallAtLeast((asyncId, type) => {
if (type === 'HTTPPARSER') {
if (type === 'HTTPINCOMINGMESSAGE' || type === 'HTTPCLIENTREQUEST') {

Trott Apr 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does HTTPCLIENTREQUEST ever actually happen here? My messing around with this for another PR has that never showing up.

Flarna Apr 24, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Honestly speaking I haven't looked into this in that detail; my focus was to repair the test and to add an assert to avoid such side effect again.
#26961 is still reproducible after #25094 was merged so there is for sure something left in this but this needs more thoughts.

Flarna Apr 24, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just tried and it seems HTTPCLIENTREQUEST is never emitted. This is for sure a bug.

Flarna commented Apr 24, 2019

Copy link
Copy Markdown
Member Author

I think the CI fails on freebsd are unrelated.

Flarna closed this Apr 24, 2019
Flarna reopened this Apr 24, 2019

Flarna commented Apr 29, 2019

Copy link
Copy Markdown
Member Author

superseded by #27477

Flarna closed this Apr 29, 2019
Flarna deleted the rename_httpparser branch April 29, 2019 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL