FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: v8, backport b901591 by alexkozy · Pull Request #27720 · nodejs/node · GitHub

/ node Public

deps: v8, backport b901591 - #27720

Closed
alexkozy wants to merge 1 commit into
nodejs:v12.xfrom
alexkozy:v8-backport
ConversationCommits (1)ChecksFiles changed
Closed

deps: v8, backport b901591#27720
alexkozy wants to merge 1 commit into
nodejs:v12.xfrom
alexkozy:v8-backport

Conversation

alexkozy commented May 15, 2019

Copy link
Copy Markdown
Member

Original commit message:

inspector: added Debugger.setInstrumentationBreakpoint method

There are two possible type:

  • scriptParsed - breakpoint for any script,
  • scriptWithSourceMapParsed - breakpoint for script with
    sourceMappingURL.

When one of the breakpoints is set then for each matched script
we add breakpoint on call to top level function of that script.

Node: #24687

R=dgozman@chromium.org

Bug: chromium:887384,chromium:724793,chromium:882909
Change-Id: I9c08b2a2a5ba7006adfedd85fc92ae191517af00
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1354245
Reviewed-by: Jakob Gruber jgruber@chromium.org
Reviewed-by: Yang Guo yangguo@chromium.org
Reviewed-by: Dmitry Gozman dgozman@chromium.org
Reviewed-by: Alexei Filippov alph@chromium.org
Commit-Queue: Aleksey Kozyatinskiy kozyatinskiy@chromium.org
Cr-Commit-Position: refs/heads/master@{#61353}

Issue: #24687

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented May 15, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3531

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 15, 2019

nodejs-github-bot commented May 18, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23183/

nodejs-github-bot commented May 18, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23187/

alexkozy mentioned this pull request May 19, 2019
Closed

BridgeAR commented May 21, 2019

Copy link
Copy Markdown
Member

@nodejs/inspector PTAL

deps: v8, backport b901591
fa2e614 
Original commit message:

inspector: added Debugger.setInstrumentationBreakpoint method

There are two possible type:
- scriptParsed - breakpoint for any script,
- scriptWithSourceMapParsed - breakpoint for script with
  sourceMappingURL.

When one of the breakpoints is set then for each matched script
we add breakpoint on call to top level function of that script.

Node: nodejs#24687
alexkozy changed the base branch from master to canary-base August 2, 2019 18:10
alexkozy changed the base branch from canary-base to master August 2, 2019 18:10
alexkozy changed the base branch from master to v12.x August 2, 2019 18:11

alexkozy commented Aug 2, 2019

Copy link
Copy Markdown
Member Author

This commit adds a method that is required to provide better-debugging experience for scripts with source maps by different IDE, e.g. VSCode. If we backport it to Node 12, we can get this support in VSCode faster.

At the same time, this commit only adds the minor feature to protocol and does not change anything around, so the risk that it breaks something is minimal.

alexkozy commented Aug 7, 2019

Copy link
Copy Markdown
Member Author

V8 backport which includes this commit is coming: #28955

alexkozy closed this Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
eugeneo eugeneo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL