FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Do not unref debug handle to avoid debug process stuck by viirya · Pull Request #2778 · nodejs/node · GitHub

/ node Public

Do not unref debug handle to avoid debug process stuck - #2778

Closed
viirya wants to merge 1 commit into
nodejs:masterfrom
viirya:no-unref-debug
ConversationCommits (1)ChecksFiles changed
Closed

Do not unref debug handle to avoid debug process stuck#2778
viirya wants to merge 1 commit into
nodejs:masterfrom
viirya:no-unref-debug

Conversation

viirya commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

For a simple javascript file:

 console.log('debug');

Run node debug a.js to launch debug process. Press first c and the program outputs > debug. After that, press c again the process just gets stuck and has no response so we have to kill it.

This is because debug handle has been unrefed. Once the program is finished, the event loop will be exited and the debug process will be stuck when debug sends commend again. We shouldn't unref the debug handle because even the script is finished, we can still send more debug command such as restart.

Fixes #1788.

mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. debugger labels Sep 9, 2015

bnoordhuis commented Sep 9, 2015

Copy link
Copy Markdown
Member

Before we go into details, have you checked that it passes make test?

viirya commented Sep 10, 2015

Copy link
Copy Markdown
Contributor Author

Thanks. I've noticed this patch would cause some tests failed. I will try to fix that.

Fishrock123 mentioned this pull request Sep 13, 2015
Closed
7 tasks

Fishrock123 commented Oct 10, 2015

Copy link
Copy Markdown
Contributor

CI?: https://ci.nodejs.org/job/node-test-pull-request/475/

ping @bnoordhuis

bnoordhuis commented Oct 10, 2015

Copy link
Copy Markdown
Member

Change itself LGTM but the commit log needs to confirm to the guidelines from CONTRIBUTING.md.

src: fixing debug process stuck
66029bf 
The debug process running "node debug a.js" will be stuck when the
script ends. This is because the debug handler has been unrefed.
We shouldn't unref the debug handler to avoid this problem.

viirya commented Oct 11, 2015

Copy link
Copy Markdown
Contributor Author

@bnoordhuis Thanks for reminding the commit log format.

viirya commented Oct 13, 2015

Copy link
Copy Markdown
Contributor Author

ping @bnoordhuis I've updated the commit log. Any other comments?

bnoordhuis pushed a commit that referenced this pull request Oct 13, 2015
src: fix stuck debugger process
ff877e9 
The debug process running "node debug a.js" will be stuck when the
script ends. This is because the debug handler has been unrefed.
We shouldn't unref the debug handler to avoid this problem.

PR-URL: #2778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis commented Oct 13, 2015

Copy link
Copy Markdown
Member

Landed in ff877e9, thanks.

bnoordhuis closed this Oct 13, 2015
This was referenced Oct 27, 2015
Merged
Closed
jasnell pushed a commit that referenced this pull request Oct 28, 2015
src: fix stuck debugger process
dee9c74 
The debug process running "node debug a.js" will be stuck when the
script ends. This is because the debug handler has been unrefed.
We shouldn't unref the debug handler to avoid this problem.

PR-URL: #2778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell commented Oct 28, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in dee9c74

This was referenced Oct 29, 2015
Merged
Merged

bnoordhuis commented Oct 29, 2015

Copy link
Copy Markdown
Member

Just a heads up but this PR introduced a regression and I'm moving to revert it, please see #3585.

jasnell commented Oct 29, 2015

Copy link
Copy Markdown
Member

@bnoordhuis ... ugh... ok

bnoordhuis mentioned this pull request Oct 29, 2015
Closed
rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins mentioned this pull request Jan 14, 2016
Closed
reshnm mentioned this pull request Apr 21, 2016
Closed
3 tasks
leonardoadame mentioned this pull request Jul 8, 2023
Open
aliscco mentioned this pull request Jul 9, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL