add experimental wasi module support on top of wasm modules - #27850
Closed
devsnek wants to merge 1 commit into
Closed
add experimental wasi module support on top of wasm modules#27850devsnek wants to merge 1 commit into
devsnek wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3612 |
Sorry, something went wrong.
devsnek
force-pushed
the
feature/wasi
branch
2 times, most recently
from
6cb5900 to
9304df9
Compare
May 24, 2019 13:47
Copy link
Copy Markdown
Member
Author
|
i tried to set up the test/wasi directory but the test runner isn't recognizing test/wasi/test.js as a test file @nodejs/testing |
Sorry, something went wrong.
devsnek
commented
May 24, 2019
Comment thread
test/wasi/test.js
Outdated
MaxGraey
reviewed
May 24, 2019
Comment thread
lib/internal/wasi.js
Outdated
lukewagner
reviewed
May 24, 2019
Comment thread
test/wasi/README.md
Outdated
Copy link
Copy Markdown
There was a problem hiding this comment.
\o/ \o/ Really excited this is testing and running vanilla clang/wasi-sysroot output.
Sorry, something went wrong.
addaleax
reviewed
May 26, 2019
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🎉
Sorry, something went wrong.
Comment thread
src/node_options.cc
Outdated
ofrobots
reviewed
May 29, 2019
ofrobots
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looking great! Thanks for putting this together. I'm experimenting with some 'real world' code that relies on this over at https://github.com/ofrobots/brotli-wasm.
Sorry, something went wrong.
Comment thread
src/node_options.cc
Outdated
devsnek
force-pushed
the
feature/wasi
branch
2 times, most recently
from
4095270 to
8373c5d
Compare
May 29, 2019 18:27
cjihrig
reviewed
May 30, 2019
Comment thread
test/wasi/test.js
Outdated
Copy link
Copy Markdown
|
This is awesome! Great work on the PR 👏 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Did this get resolved or is it still a problem? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@devsnek, rename test/wasi/test.js to test/wasi/test-wasi.js (or something else that begins with test-) and it should work. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@cjihrig i attempted to add seeking but the native function keeps returning undefined on success instead of the new offset ;(. if anyone better with napi sees the bug please let me know |
Sorry, something went wrong.
cjihrig
reviewed
Jun 3, 2019
Comment thread
src/node_wasi.cc
Outdated
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Sep 24, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Sep 25, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Sep 26, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Sep 30, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Sep 30, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 7, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 7, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 9, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 9, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 14, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 14, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 15, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 15, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 28, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 28, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 30, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 30, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 31, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Oct 31, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Nov 2, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Nov 2, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Nov 4, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Nov 4, 2019
This commit adds support for resolving symlinks during path resolution. This commit also ports all of the remaining tests from nodejs/node#27850, with the 'poll' test currently disabled.
cjihrig
added a commit
to nodejs/wasi
that referenced
this pull request
Nov 5, 2019
This commit ports the following tests from nodejs/node#27850. - clock_getres - getentropy (currently disabled) - getrusage - gettimeofday - notdir - preopen_populates - read_file_twice - stat - stdin - write_file This commit completes the implementations of fd_filestat_get() and path_filestat_get(), which are needed for the stat test. This commit also adds clock_res_get() and partial clock_time_get() support.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lukewagner @linclark @guybedford @tschneidereit @ofrobots
Checklist