FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: create github support file by devsnek · Pull Request #27926 · nodejs/node · GitHub

/ node Public

meta: create github support file - #27926

Closed
devsnek wants to merge 3 commits into
nodejs:masterfrom
devsnek:support-file
ConversationCommits (3)ChecksFiles changed
Closed

meta: create github support file#27926
devsnek wants to merge 3 commits into
nodejs:masterfrom
devsnek:support-file

Conversation

devsnek commented May 27, 2019

Copy link
Copy Markdown
Member

@nodejs/tsc @nodejs/community-committee

Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project

Checklist

devsnek added the meta Issues and PRs related to the general management of the project. label May 27, 2019
Trott self-assigned this May 27, 2019
Trott requested changes May 27, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The shorthand links won't work without the references at the bottom. I'd inline all of them, though, so that people looking at this in a text editor can understand it easier.

Trott commented May 27, 2019

Copy link
Copy Markdown
Member

(I'd also recommend replacing the information in README with a link to this file so we don't have to update information in two places.)

Trott commented May 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This is what I was going to propose, if it helps: master...Trott:support-file

meta: create github support file
dd65fdc 
Refs: help.github.com/en/articles/adding-support-resources-to-your-project
Trott removed their assignment May 27, 2019

Trott commented May 27, 2019

Copy link
Copy Markdown
Member

Looks like maybe the lite CI's didn't start automatically. Here's a manually-started Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3629/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 27, 2019
keywordnew reviewed May 27, 2019
View reviewed changes

keywordnew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great folks!

My non-blocking comment would be to add what the suggested resources are good for, so unfamiliar people can make better choices without as much guesswork.

For example:

* [Node.js Website](https://nodejs.org/en/)
Good for general information, links to latest changelogs, API docs.

bnb approved these changes May 27, 2019
View reviewed changes

bnb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Other than these small changes, LGTM.

Comment thread .github/SUPPORT.md
Comment thread .github/SUPPORT.md Outdated

bnb commented May 27, 2019

Copy link
Copy Markdown
Contributor

Thank you @devsnek for PRng this in! 💖

Update .github/SUPPORT.md
082675a 
Co-Authored-By: Tierney Cyren <accounts@bnb.im>
Trott reviewed May 28, 2019
View reviewed changes
Comment thread .github/SUPPORT.md Outdated
Update .github/SUPPORT.md
c19ddef 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
watilde approved these changes May 28, 2019
View reviewed changes

watilde left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

<3

Trott commented May 28, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3631/

mcollina approved these changes May 28, 2019
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in f469522

Trott closed this May 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
meta: create github support file
f469522 
PR-URL: nodejs#27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 31, 2019
meta: create github support file
d982f0b 
PR-URL: #27926
Refs: https://help.github.com/en/articles/adding-support-resources-to-your-project
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
devsnek deleted the support-file branch June 1, 2019 14:08
targos mentioned this pull request Jun 3, 2019
Merged
richardlau mentioned this pull request Jun 3, 2019
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnb bnb approved these changes
Trott Trott approved these changes
mcollina mcollina approved these changes
watilde watilde approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+2 more reviewers
keywordnew keywordnew left review comments
WaleedAshraf WaleedAshraf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL