SGTM

LGTM

@fansworld-claudio can you link to buffer.html#buffer_buffer? That anchor is closer to the list of encodings. Maybe also use a shared anchor (see the bottom of many markdown files) for both links.

@silverwind Good idea, change pushed.

@silverwind .. since you had the last comment to be address can you PTAL.
meanwhile, LGTM

LGTM

Landed in 30ce3eb

landed in lts-v4.x-staging as 5689630

@thealphanerd you only landed one of these commits, the other, 87c6c77, is not on v4.x but it doesn't land cleanly.

I'd suggest either leaving that one off v4.x or, @fansworld-claudio if you'd like to submit a PR for that commit against v4.x-staging then we can land it.

@rvagg ... if I recall correctly, the commit that actually landed in master was squashed into a single commit (5689630). It looks like @thealphanerd picked that commit into v4.x-staging which is why the second commit here doesn't appear and doesn't land clean. (I could be wrong tho)

$ git log master --format='%h %an: %s' | grep fansworld-claudio
2a29b70 fansworld-claudio: doc: url.format - true slash postfix behaviour
9a628e2 fansworld-claudio: test: module loading error fix solaris #3798
30ce3eb fansworld-claudio: docs: fs - change links to buffer encoding to Buffer class anchor
2e38079 fansworld-claudio: docs: fs - remove encoding list and link to buffer
49f965c fansworld-claudio: docs: add missing shell option to execSync

30ce3eb and 2e38079

They show up in branch-diff, when comparing v4.x-staging to master:

• [2e38079ea4] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)

And v4.x-staging to v5.x:

• [7a84fa6c60] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)

@rvagg looks like we are now stuck with 7a84fa6 forever showing up as a false positive when doing audits... perhaps there is a way to add meta data to the comments inside the commit that branch-diff / changelog maker can use?