FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

completed secure-pair performance test with clear connections by tufosa · Pull Request #27971 · nodejs/node · GitHub

/ node Public

completed secure-pair performance test with clear connections - #27971

Closed
tufosa wants to merge 2 commits into
nodejs:masterfrom
tufosa:master
ConversationCommits (2)ChecksFiles changed
Closed

completed secure-pair performance test with clear connections#27971
tufosa wants to merge 2 commits into
nodejs:masterfrom
tufosa:master

Conversation

tufosa commented May 30, 2019

Copy link
Copy Markdown

A very simple patch to the existing secure-pair benchmark in order to include clear connections in the test and expose this issue

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

benchmark: added clear connections to secure-pair performance test
509bf09 
adds clear connections to the secure-pair performance test to prove
thah in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Refs: nodejs#27970
nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. tls Issues and PRs related to the tls subsystem. labels May 30, 2019
tufosa mentioned this pull request May 30, 2019
Open

addaleax commented May 30, 2019

Copy link
Copy Markdown
Member

@tufosa Does it make sense to add a smaller chunk size to benchmark/net/net-pipe.js?

tufosa commented May 30, 2019

Copy link
Copy Markdown
Author

@addaleax yep!! Didn't know about this benchmark. Done in 809ee8c. The test with chunks of 2 bytes performs 100 times worse than the 64 bytes one.

tufosa commented Jul 17, 2019

Copy link
Copy Markdown
Author

@addaleax it's my first PR to this project and I am not sure how can we move this forward. Everything seems OK, but I don't know if I need to do anything else in order to get this reviewed and eventually approved. Can you help me with this?

gireeshpunathil commented Dec 18, 2019

Copy link
Copy Markdown
Member

ping @addaleax

nodejs-github-bot commented Dec 18, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27780/

addaleax approved these changes Dec 18, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gireeshpunathil Anything in particular I’d need to be aware of here?

gireeshpunathil commented Dec 18, 2019

Copy link
Copy Markdown
Member

@addaleax - no, I pinged because I see this PR not moving and saw you as the only person engaged on this PR so far; so!

nodejs-github-bot commented Dec 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27802/

nodejs-github-bot commented Dec 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27826/

gireeshpunathil pushed a commit that referenced this pull request Dec 20, 2019
benchmark: add clear connections to secure-pair
fc553fd 
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gireeshpunathil commented Dec 20, 2019

Copy link
Copy Markdown
Member

landed in fc553fd thanks for the contribution!

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
benchmark: add clear connections to secure-pair
625744d 
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
benchmark: add clear connections to secure-pair
8c3b8e0 
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
benchmark: add clear connections to secure-pair
aa973c5 
adds clear connections to the secure-pair performance test to prove
that in some cases (when the sender send the data in small chunks)
clear connections perform worse than TLS connections

Also add a byte chunk size test to benchmark/net/net-pipe.js

Refs: #27970

PR-URL: #27971
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Feb 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL