FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

process: disallow some uses of Object.defineProperty() on process.env by himself65 · Pull Request #28006 · nodejs/node · GitHub

/ node Public

process: disallow some uses of Object.defineProperty() on process.env - #28006

Merged
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
himself65:27990
Apr 4, 2022
ConversationCommits (4)ChecksFiles changed
Merged

process: disallow some uses of Object.defineProperty() on process.env#28006
nodejs-github-bot merged 4 commits into
nodejs:masterfrom
himself65:27990

Conversation

himself65 commented Jun 1, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

try to fix #27990

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 1, 2019
addaleax reviewed Jun 1, 2019
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I’m labelling this semver-major because it adds a throw, but I don’t have a strong opinion on that and we can remove it if somebody feels differently.

Comment thread src/node_env_var.cc Outdated
Comment thread doc/api/process.md Outdated
addaleax added process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels Jun 1, 2019
Trott approved these changes Jun 1, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green. (I think I'd prefer that we throw an error with a code property, but that can always be changed later.)

This comment has been minimized.

Sign in to view
himself65 force-pushed the 27990 branch 2 times, most recently from d30c5e6 to 40bdd0c Compare June 2, 2019 03:16

nodejs-github-bot commented Jun 3, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23584/

bnoordhuis approved these changes Jun 3, 2019
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM % comment.

Comment thread src/node_env_var.cc Outdated
himself65 force-pushed the 27990 branch 13 times, most recently from 5d63629 to 6b9d9cb Compare June 3, 2019 16:54
BridgeAR reviewed Jun 4, 2019
View reviewed changes
Comment thread src/node_env_var.cc Outdated
joyeecheung reviewed Jun 5, 2019
View reviewed changes
Comment thread src/node_env_var.cc Outdated
himself65 force-pushed the 27990 branch 2 times, most recently from 75fa512 to 59b5175 Compare June 5, 2019 15:02

himself65 commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Ok, i will take a look

process: disallow some uses of Object.defineProperty() on process.env
e65bb10 
Disallow the use of Object.defineProperty() to hide entries in
process.env or make them immutable.
himself65 commented Jan 12, 2022
View reviewed changes
Comment thread src/node_env_var.cc Outdated
ljharb reviewed Jan 12, 2022
View reviewed changes
Comment thread src/node_env_var.cc Outdated
Comment thread src/node_env_var.cc Outdated

himself65 commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

hope the test will pass

himself65 commented Jan 12, 2022

Copy link
Copy Markdown
Member Author 
Download action repository 'actions/checkout@v2' (SHA:ec3a7ce113134d7a93b817d10a8272cb61118579)
Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ec3a7ce113134d7a93b817d10a8272cb61118579'. Error: Response status code does not indicate success: 503 (Service Unavailable).
Warning: Back off 25.2 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/ec3a7ce113134d7a93b817d10a8272cb61118579'. Error: Response status code does not indicate success: 503 (Service Unavailable).
Warning: Back off 12.773 seconds before retry.
Error: Response status code does not indicate success: 503 (Service Unavailable).

himself65 commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

why all ci crash and only happen in my pr?

himself65 commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

why all ci crash and only happen in my pr?

https://www.githubstatus.com/incidents/cypv026dr23w

himself65 commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

@ljharb could u please take a look? thanks

ljharb commented Jan 13, 2022

Copy link
Copy Markdown
Member

LGTM!

aduh95 reviewed Jan 14, 2022
View reviewed changes
Comment thread doc/api/errors.md Outdated
Update doc/api/errors.md
46acbbe 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 14, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022

This comment was marked as outdated.

Sign in to view
This was referenced Jan 15, 2022
Open
Open
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2022

nodejs-github-bot commented Apr 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43299/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2022

nodejs-github-bot commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

Landed in e6a7300

BethGriggs mentioned this pull request Apr 9, 2022
Merged
Renegade334 mentioned this pull request Nov 1, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments
addaleax addaleax left review comments
BridgeAR BridgeAR left review comments
ZYSzys ZYSzys left review comments
bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
Trott Trott approved these changes
joyeecheung joyeecheung approved these changes
gireeshpunathil gireeshpunathil approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
fhinkel fhinkel left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. notable-change PRs with changes that should be highlighted in changelogs. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot delete property from process.env
Back | FazBrowse Home | New Git URL