FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: replace var with let by mbj36 · Pull Request #28081 · nodejs/node · GitHub

/ node Public

lib: replace var with let - #28081

Closed
mbj36 wants to merge 1 commit into
nodejs:masterfrom
mbj36:master
ConversationCommits (1)ChecksFiles changed
Closed

lib: replace var with let#28081
mbj36 wants to merge 1 commit into
nodejs:masterfrom
mbj36:master

Conversation

mbj36 commented Jun 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

himself65 requested changes Jun 6, 2019
View reviewed changes

himself65 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

there still have many var left.
is this change necessary?

see: https://github.com/nodejs/node/search?utf8=✓&q=for+(var&type=

ZYSzys commented Jun 6, 2019

Copy link
Copy Markdown
Member

FYI, here are some references: #26504, #26679, #26915

himself65 commented Jun 6, 2019

Copy link
Copy Markdown
Member

thanks. I get it

antsmartian added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 7, 2019

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23946/

nodejs-github-bot commented Jun 21, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24034/

nodejs-github-bot commented Jun 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24090/

nodejs-github-bot commented Jun 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24102/

Trott commented Jun 25, 2019

Copy link
Copy Markdown
Member

This can be done by whoever lands this, but the commit message should probably be more specific. It currently makes it sound like this applies to all instances in lib. Maybe it can be lib: replace var with let in loaders.js?

BridgeAR added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jul 5, 2019

nodejs-github-bot commented Jul 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24280/

nodejs-github-bot commented Jul 14, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24442/

mhdawson approved these changes Jul 17, 2019
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24756/

nodejs-github-bot commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24767/

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

Landed in 863402e

Trott closed this Jul 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 30, 2019
lib: replace var with let in loaders.js
863402e 
PR-URL: nodejs#28081
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
lib: replace var with let in loaders.js
464136f 
PR-URL: #28081
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BridgeAR mentioned this pull request Aug 6, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

himself65 himself65 requested changes
jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+2 more reviewers
antsmartian antsmartian approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL