FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: rename validateKeyCert in _tls_common.js by danbev · Pull Request #28116 · nodejs/node · GitHub

/ node Public

tls: rename validateKeyCert in _tls_common.js - #28116

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:validateKeyCertArg
ConversationCommits (2)ChecksFiles changed
Closed

tls: rename validateKeyCert in _tls_common.js#28116
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:validateKeyCertArg

Conversation

danbev commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

This commit renames validateKeyCert to validateKeyCertArg to avoid
confusing this with something that would validate the actual key or
certificate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Jun 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23843/

nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jun 7, 2019

nodejs-github-bot commented Jun 7, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23687/

mscdex commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

s/_tls_commons/_tls_common/ in commit message

mscdex commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Also I think the subsystem prefix should be tls: instead of crypto:.

tls: rename validateKeyCert in _tls_common.js
d048ddb 
This commit renames validateKeyCert to validateKeyCertArg to avoid
confusing this with something that would validate the actual key or
certificate.
danbev force-pushed the validateKeyCertArg branch from 2b85de2 to d048ddb Compare June 7, 2019 06:45

danbev commented Jun 7, 2019

Copy link
Copy Markdown
Contributor Author

@mscdex Thanks, I've fixed both issues now.

danbev changed the title crypto: rename validateKeyCert in _tls_commons.js tls: rename validateKeyCert in _tls_common.js Jun 7, 2019

sam-github commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

I'm fine with this, as-is, but maybe validateKeyOrCertOption() would be more accurate? It's not being validated that its the key's cert, and its passed as an option, not an arg (though the error is ERR_INVALID_ARG_TYPE).

danbev commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

I'm fine with this, as-is, but maybe validateKeyOrCertOption() would be more accurate?

I like that better. I've updated with a commit now. Thanks

This comment has been minimized.

Sign in to view
danbev added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 12, 2019

Trott commented Jun 13, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/23843/

Trott commented Jun 13, 2019

Copy link
Copy Markdown
Member

Landed in 173bee2

Trott closed this Jun 13, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 13, 2019
tls: rename validateKeyCert in _tls_common.js
173bee2 
This commit renames validateKeyCert to validateKeyCertArg to avoid
confusing this with something that would validate the actual key or
certificate.

PR-URL: nodejs#28116
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
tls: rename validateKeyCert in _tls_common.js
6b9d477 
This commit renames validateKeyCert to validateKeyCertArg to avoid
confusing this with something that would validate the actual key or
certificate.

PR-URL: #28116
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR mentioned this pull request Jun 17, 2019
Merged
danbev deleted the validateKeyCertArg branch August 20, 2019 07:43
kissofire mentioned this pull request Jul 22, 2022
Open
wedataintelligence mentioned this pull request Jul 22, 2022
Open
ron-a20 mentioned this pull request Jul 22, 2022
Open
Dmarch28 mentioned this pull request Jul 22, 2022
Open
aliceUnhinged613 mentioned this pull request Jul 22, 2022
Open
137717unity mentioned this pull request Jul 22, 2022
Open
baby636 mentioned this pull request Jul 22, 2022
Open
molllyn1 mentioned this pull request Jul 23, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
sam-github sam-github approved these changes
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL