doc: resolve ambiguity in pull-requests.md - #28125
Closed
rexagod wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
reviewed
Jun 8, 2019
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Trott
reviewed
Jun 8, 2019
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Trott
reviewed
Jun 8, 2019
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Copy link
Copy Markdown
Member
|
Left a few suggestions but they're totally optional as they address things that are already in the document rather than things that are introduced in this pull request. |
Sorry, something went wrong.
Trott
reviewed
Jun 9, 2019
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Trott
reviewed
Jun 9, 2019
Comment thread
doc/guides/contributing/pull-requests.md
Outdated
Resolved ambiguous meanings for the term `body of commit message` in `pull-requests.md` file, Fixes: nodejs#28068
Trott
approved these changes
Jun 9, 2019
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Pinging @trivikr to approve this if all seems fine, thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed in 558f834 |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 16, 2019
Resolved ambiguous meanings for the term `body of commit message` in `pull-requests.md` file, Fixes: nodejs#28068 PR-URL: nodejs#28125 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved ambiguous meanings for the term body of commit message
in pull-requests.md file
Fixes: #28068
Checklist