doc: fix prohibited-strings warning in pull-requests.md - #28127
Conversation
Sorry, something went wrong.
|
Anyone know why that file isn't getting linted with make lint-md? Seems to me like it ought to be. I'm probably not seeing some setting somewhere that disables stuff for the directory or something like that? |
Sorry, something went wrong.
The ** in Line 1162 in 6447be6 |
Sorry, something went wrong.
|
#28128 should fix the Makefile so that it lints all the *.md files under doc including the ones in nested subdirectories like the one being fixed in this PR. |
Sorry, something went wrong.
Sorry, something went wrong.
Correct "Github" to "GitHub" in compliance to the linting standards. PR-URL: nodejs#28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Sorry, something went wrong.
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: nodejs#28128 Refs: nodejs#28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Correct "Github" to "GitHub" in compliance to the linting standards. PR-URL: #28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
`**` expansion doesn't behave as expected and as a result files in nested subdirectories under `doc` were not linted. Use `find` instead to generate the list of files to lint. PR-URL: #28128 Refs: #28127 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
corrected "Github" to "GitHub" in compliance
to the linting standards
Checklist
Warn log