test: remove duplicate test-child-process-execfilesync-maxBuffer.js - #28139
test: remove duplicate test-child-process-execfilesync-maxBuffer.js#28139joyeecheung wants to merge 1 commit into
Conversation
Sorry, something went wrong.
In addition correct the comment about what it does.
|
Sadly, an error occurred when I tried to trigger a build. :( |
Sorry, something went wrong.
Sorry, something went wrong.
|
Micro-nit: Is maxBuffer perhaps the ever-so-slightly better file name part since it clearly reflects what's being tested? (Like, if someone is looking for maxBuffer tests, they might do a case-insensitive grep for filenames with maxBuffer and miss it if it's maxbuf instead?) |
Sorry, something went wrong.
|
@Trott There is also test-child-process-spawnsync-maxbuf.js, and a few other child process tests that do all lower-cases...I guess we should leave that to a future PR to change all these? |
Sorry, something went wrong.
In addition correct the comment about what it does. PR-URL: nodejs#28139 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In addition correct the comment about what it does. PR-URL: #28139 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
In addition correct the comment about what it does.
This is produced by
If you use https://github.com/nodejs/node/pull/28139/files?w=1 to view the diff you can see they aren't doing anything too different.
Checklist