FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: pass path in URL constructor by dnalborczyk · Pull Request #28161 · nodejs/node · GitHub

/ node Public

doc: pass path in URL constructor - #28161

Closed
dnalborczyk wants to merge 1 commit into
nodejs:masterfrom
dnalborczyk:esm-doc-url
Closed

doc: pass path in URL constructor#28161
dnalborczyk wants to merge 1 commit into
nodejs:masterfrom
dnalborczyk:esm-doc-url

Conversation

dnalborczyk commented Jun 10, 2019
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

simplifies doc

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2019

ZYSzys commented Jun 14, 2019

Copy link
Copy Markdown
Member

ZYSzys added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 14, 2019

ZYSzys commented Jun 14, 2019

Copy link
Copy Markdown
Member

Landed in b5e8181 🎉

ZYSzys closed this Jun 14, 2019
ZYSzys pushed a commit that referenced this pull request Jun 14, 2019
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR mentioned this pull request Jun 17, 2019
targos pushed a commit that referenced this pull request Jun 18, 2019
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL