FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document behavior of family:0 in dns.lookup() by cjihrig · Pull Request #28163 · nodejs/node · GitHub

/ node Public

doc: document behavior of family:0 in dns.lookup() - #28163

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dns-docs
ConversationCommits (1)ChecksFiles changed
Closed

doc: document behavior of family:0 in dns.lookup()#28163
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dns-docs

Conversation

cjihrig commented Jun 11, 2019

Copy link
Copy Markdown
Contributor

Fixes: #28159

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Jun 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23829/
CI: https://ci.nodejs.org/job/node-test-pull-request/23833/

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Jun 11, 2019

ZYSzys commented Jun 14, 2019

Copy link
Copy Markdown
Member

Landed in 282e2f6.

ZYSzys closed this Jun 14, 2019
ZYSzys mentioned this pull request Jun 14, 2019
Closed
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
doc: document behavior of family:0 in dns.lookup()
3780683 
Fixes: #28159

PR-URL: #28163
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
doc: document behavior of family:0 in dns.lookup()
4cadddc 
Fixes: #28159

PR-URL: #28163
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig deleted the dns-docs branch June 19, 2019 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dns docs are missing that family = 0 for dns.lookup is allowed

8 participants

Back | FazBrowse Home | New Git URL