FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check custom inspection truncation in assert by Trott · Pull Request #28234 · nodejs/node · GitHub

/ node Public

test: check custom inspection truncation in assert - #28234

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:check-truncation
ConversationCommits (1)ChecksFiles changed
Closed

test: check custom inspection truncation in assert#28234
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:check-truncation

Conversation

Trott commented Jun 14, 2019

Copy link
Copy Markdown
Member

The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

The previously-uncovered lines are

node/lib/internal/assert/assertion_error.js

Lines 437 to 442 in b614840

if (lines.length > 10) {
lines.length = 10;
this[name] = `${lines.join('\n')}\n...`;
} else if (this[name].length > 512) {
this[name] = `${this[name].slice(512)}...`;
}
.

@BridgeAR I could use some confirmation that this is covering a feature and not revealing a bug. When an ASSERTION_ERROR with a long line is inspected, the value in actual or expected will be truncated but the same value will appear in full in the message. Whoops? Or by design?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This comment has been minimized.

Sign in to view
nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 14, 2019
Trott added the assert Issues and PRs related to the assert subsystem. label Jun 14, 2019

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Trott commented Jun 15, 2019

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/23901/

BridgeAR commented Jun 15, 2019

Copy link
Copy Markdown
Member

@Trott

@BridgeAR I could use some confirmation that this is covering a feature and not revealing a bug. When an ASSERTION_ERROR with a long line is inspected, the value in actual or expected will be truncated but the same value will appear in full in the message. Whoops? Or by design?

It is by design: we used to only visualize the stack property in case of a fatal exception and other cases. I changed that recently to fully inspect errors on fatal exceptions. Now all properties on an error will be fully inspected. Since the actual and expected values will be visible in the message anyway, it's better to minimize the output for the properties by default, since it would otherwise duplicate the information and that seems pretty verbose. That was the original reason for me to limit the output for these properties.

BridgeAR approved these changes Jun 15, 2019
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks for writing the tests for this!

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 15, 2019
joyeecheung mentioned this pull request Jun 16, 2019
Closed
danbev approved these changes Jun 18, 2019
View reviewed changes
Comment thread test/parallel/test-assert.js Outdated

danbev Jun 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: sould -> should

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jun 18, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23957/

test: check custom inspection truncation in assert
e3d5257 
The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

PR-URL: nodejs#28234
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Trott force-pushed the check-truncation branch from 09888e3 to e3d5257 Compare June 18, 2019 18:17

Trott commented Jun 18, 2019

Copy link
Copy Markdown
Member Author

Landed in e3d5257

Trott closed this Jun 18, 2019
Trott deleted the check-truncation branch June 18, 2019 18:17
targos pushed a commit that referenced this pull request Jul 2, 2019
test: check custom inspection truncation in assert
d949ead 
The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

PR-URL: #28234
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR approved these changes
+1 more reviewer
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL