FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix cctest target for --without-report by richardlau · Pull Request #28238 · nodejs/node · GitHub

/ node Public

build: fix cctest target for --without-report - #28238

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:fix-without-report
ConversationCommits (1)ChecksFiles changed
Closed

build: fix cctest target for --without-report#28238
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:fix-without-report

Conversation

richardlau commented Jun 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Conditionally build test/cctest/test_report_util.cc only when
configured to include the diagnostic report feature.

Fixes the following link error when configured with --without-report:

/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o: In function `ReportUtilTest_EscapeJsonChars_Test::TestBody()':
test_report_util.cc:(.text+0x57): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x1ad): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x302): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x44a): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x592): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o:test_report_util.cc:(.text+0xd7a): more undefined references to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' follow
collect2: error: ld returned 1 exit status
make[1]: *** [/home/users/riclau/sandbox/github/nodejs/out/Release/cctest] Error 1

cc @nodejs/build-files

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

build: fix cctest target for --without-report
962dd6e 
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

nodejs-github-bot commented Jun 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23896/
CI: https://ci.nodejs.org/job/node-test-pull-request/23899/

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 15, 2019
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 17, 2019

BridgeAR commented Jun 17, 2019

Copy link
Copy Markdown
Member

Landed in c72506c 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jun 17, 2019
build: fix cctest target for --without-report
c72506c 
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: nodejs#28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR closed this Jun 17, 2019
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
build: fix cctest target for --without-report
366c983 
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: #28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
build: fix cctest target for --without-report
ddef3d0 
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: #28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL