FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: update LICENSE by Trott · Pull Request #28260 · nodejs/node · GitHub

/ node Public

meta: update LICENSE - #28260

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:license-updates-yo
Jun 19, 2019
Merged

meta: update LICENSE#28260
Trott merged 1 commit into
nodejs:masterfrom
Trott:license-updates-yo

Conversation

Trott commented Jun 17, 2019

Copy link
Copy Markdown
Member

A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This comment has been minimized.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 17, 2019

Trott commented Jun 17, 2019
edited
Loading

Copy link
Copy Markdown
Member Author

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 17, 2019

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

PR-URL: nodejs#28260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Trott force-pushed the license-updates-yo branch from e93f68a to e585846 Compare June 19, 2019 04:17

Trott commented Jun 19, 2019

Copy link
Copy Markdown
Member Author

Landed in e585846

Trott merged commit e585846 into nodejs:master Jun 19, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
A few dependencies have been updated or added without running
license_builder.sh. This updates based on current master branch.

PR-URL: #28260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos mentioned this pull request Jul 2, 2019
Trott deleted the license-updates-yo branch January 13, 2022 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL