FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update babel-eslint to 10.0.2 by ZYSzys · Pull Request #28266 · nodejs/node · GitHub

/ node Public

tools: update babel-eslint to 10.0.2 - #28266

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:babel-eslint
Closed

tools: update babel-eslint to 10.0.2#28266
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:babel-eslint

Conversation

ZYSzys commented Jun 17, 2019
edited
Loading

Copy link
Copy Markdown
Member

Update babel-eslint to 10.0.2 by running tools/update-babel-eslint.sh.

Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 17, 2019

ZYSzys commented Jun 17, 2019

Copy link
Copy Markdown
Member Author

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

This seems to add a few files that were missing before 👍 (even though it seems like we did not require them).

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 17, 2019

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Non-rubber-stamp LGTM. The change set is manageable so I was able to actually review it. :-D

ZYSzys commented Jun 20, 2019

Copy link
Copy Markdown
Member Author

Landed in d698983.

ZYSzys closed this Jun 20, 2019
ZYSzys deleted the babel-eslint branch June 20, 2019 05:56
targos pushed a commit that referenced this pull request Jul 2, 2019
PR-URL: #28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL