FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document PerformanceNodeTiming.environment field by yvasiyarov · Pull Request #28280 · nodejs/node · GitHub

/ node Public

doc: document PerformanceNodeTiming.environment field - #28280

Closed
yvasiyarov wants to merge 1 commit into
nodejs:masterfrom
yvasiyarov:perf_hook_doc
ConversationCommits (1)ChecksFiles changed
Closed

doc: document PerformanceNodeTiming.environment field#28280
yvasiyarov wants to merge 1 commit into
nodejs:masterfrom
yvasiyarov:perf_hook_doc

Conversation

yvasiyarov commented Jun 18, 2019

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Jun 18, 2019
Trott requested changes Jun 18, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Welcome @yvasiyarov and thanks for the pull request! If you look at the other performanceNodeTiming entries, they are in alphabetical order. So instead of putting this one at the end, can you put it in the alphabetized location in the list? Thanks!

yvasiyarov commented Jun 19, 2019

Copy link
Copy Markdown
Author

@Trott fixed. commit squashed with original commit

cjihrig approved these changes Jun 19, 2019
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the sorting nit addressed.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 20, 2019

Trott commented Jun 20, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3695/

Trott commented Jun 21, 2019

Copy link
Copy Markdown
Member

Landed in 7334aaf

Trott closed this Jun 21, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 21, 2019
doc: document PerformanceNodeTiming.environment field
7334aaf 
PR-URL: nodejs#28280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Jun 21, 2019

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Jul 2, 2019
doc: document PerformanceNodeTiming.environment field
57ac661 
PR-URL: #28280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL