FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix order of assertion arguments in test-buffer-indexof by MistyBlunch · Pull Request #28359 · nodejs/node · GitHub

/ node Public

test: fix order of assertion arguments in test-buffer-indexof - #28359

Closed
MistyBlunch wants to merge 3 commits into
nodejs:masterfrom
MistyBlunch:master
ConversationCommits (3)ChecksFiles changed
Closed

test: fix order of assertion arguments in test-buffer-indexof#28359
MistyBlunch wants to merge 3 commits into
nodejs:masterfrom
MistyBlunch:master

Conversation

MistyBlunch commented Jun 21, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 21, 2019
Trott requested changes Jun 21, 2019
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Welcome @MistyBlunch and thanks for the pull request! There appears to be an unrelated change in this pull request that should be removed. Additionally, the commit message can be improved. Perhaps this?: test: fix order of assertion arguments in test-buffer-indexof Hope this help!

Comment thread tools/macos-firewall.sh Outdated
MistyBlunch changed the title test: change order of arguments test: fix order of assertion arguments in test-buffer-indexof Jun 21, 2019
addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 22, 2019

nodejs-github-bot commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24062/

jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jun 23, 2019

addaleax commented Jun 25, 2019

Copy link
Copy Markdown
Member

Landed in 6966e15

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

addaleax closed this Jun 25, 2019
pull Bot pushed a commit to Pandinosaurus/node that referenced this pull request Jun 25, 2019
test: change order of arguments
6966e15 
PR-URL: nodejs#28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
test: change order of arguments
4bca4a5 
PR-URL: #28359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL