doc: add example of event close for child_process - #28376
Closed
ltciro wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
reviewed
Jun 23, 2019
Comment thread
doc/api/child_process.md
| ```js | ||
| const { spawn } = require('child_process'); | ||
| const ls = spawn('ls', ['-lh', '/usr']); | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One suggestion for the example :-)
Suggested change
| ls.stdout.setEncoding('utf8'); |
Sorry, something went wrong.
jasnell
approved these changes
Jun 23, 2019
Copy link
Copy Markdown
Member
|
@nodejs/documentation This duplicates sample code from elsewhere in the doc. Is this how we want to do this sort of thing? Would a more succinct example which focuses on close be a better fit here? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Jul 30, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
PR-URL: nodejs#28376 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28376 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a missing example of the event close for child_process
Checklist