tools: update remark-preset-lint-node to 1.7.0 - #28393
Merged
Trott merged 0 commit intoJun 27, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
/ping @nodejs/linting |
Sorry, something went wrong.
richardlau
approved these changes
Jun 26, 2019
Copy link
Copy Markdown
Member
Author
|
A note on landing this, in case someone other than me does it: Be sure to run make lint-md before pushing the commit to upstream. It's possible that some violations of the newly-added lint constraint have been committed since this was opened. Probably not, but if so, those will need to be fixed while landing this. |
Sorry, something went wrong.
trivikr
approved these changes
Jun 26, 2019
watilde
approved these changes
Jun 27, 2019
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This update enables linting for "note that" in our docs. That phrase is almost always superfluous. Sentences are almost always clearer and stronger without it. PR-URL: #28393 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update enables linting for "note that" in our docs. That phrase is
almost always superfluous. Sentences are almost always clearer and
stronger without it.
Checklist