docs: clarify response.finished - #28411
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Jun 24, 2019
Trott
approved these changes
Jun 25, 2019
Comment thread
doc/api/http.md
Outdated
jasnell
approved these changes
Jun 25, 2019
lpinca
approved these changes
Jun 26, 2019
trivikr
approved these changes
Jun 26, 2019
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 27, 2019
PR-URL: nodejs#28411 Refs: jshttp/on-finished#30 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28411 Refs: jshttp/on-finished#30 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some regular confusion in regards to the response.finished property and makes it more consistent with the description for request.finished.
Refs: jshttp/on-finished#30
Checklist