FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: replace version with REPLACEME by cjihrig · Pull Request #28431 · nodejs/node · GitHub

/ node Public

doc: replace version with REPLACEME - #28431

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:replaceme
Closed

doc: replace version with REPLACEME#28431
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:replaceme

Conversation

cjihrig commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time.

Refs: #28007

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

Refs: nodejs#28007
nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 26, 2019

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍 to fast-track

cjihrig commented Jun 26, 2019
edited
Loading

Copy link
Copy Markdown
Contributor Author

richardlau added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 26, 2019

danbev commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

Landed in 5b4a0cb.

danbev closed this Jun 26, 2019
danbev pushed a commit that referenced this pull request Jun 26, 2019
Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

PR-URL: #28431
Refs: #28007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
cjihrig deleted the replaceme branch June 26, 2019 14:29
targos pushed a commit that referenced this pull request Jul 2, 2019
Node 12.4.0 has already been released. Replace the version with
REPLACEME so that the proper version gets inserted at release
time.

PR-URL: #28431
Refs: #28007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL