FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: manage MakeContext() pointer with unique_ptr by cjihrig · Pull Request #28616 · nodejs/node · GitHub

/ node Public

src: manage MakeContext() pointer with unique_ptr - #28616

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:unique-ptr
Jul 12, 2019
ConversationCommits (1)ChecksFiles changed
Merged

src: manage MakeContext() pointer with unique_ptr#28616
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:unique-ptr

Conversation

cjihrig commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

Refs: #28452

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Jul 9, 2019
addaleax approved these changes Jul 9, 2019
View reviewed changes
Comment thread src/node_contextify.cc Outdated

nodejs-github-bot commented Jul 10, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24363/

nodejs-github-bot commented Jul 10, 2019 •
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24364/

EDIT(cjihrig): CI was green.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 11, 2019
src: manage MakeContext() pointer with unique_ptr
641d57f 
PR-URL: nodejs#28616
Refs: nodejs#28452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig merged commit 641d57f into nodejs:master Jul 12, 2019
cjihrig deleted the unique-ptr branch July 12, 2019 13:10
targos pushed a commit that referenced this pull request Jul 20, 2019
src: manage MakeContext() pointer with unique_ptr
3c418d9 
PR-URL: #28616
Refs: #28452
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL